fix: show validation error for QuestionShort in NcNoteCard #3413
Open
Chartman123 wants to merge 1 commit into
Open
fix: show validation error for QuestionShort in NcNoteCard #3413Chartman123 wants to merge 1 commit into
Chartman123 wants to merge 1 commit into
Conversation
Chartman123
added
javascript
Chartman123
force-pushed
the
fix/validation-error
branch
from
1e4ba41 to
76d00e8
Compare
also add missing aria error handling Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
fix/validation-error
branch
from
76d00e8 to
485d85e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding custom validation with
@invalid.prevent="validate"in #3382 the validation in QuestionShort didn't work as expected anymore.The validation was refactored to also make use of the NcNoteCard to fix the issue.
While fixing this I realized that the aria-messages about errors were also missing in the above mentioned PR and so I added them here as well.